Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into CLI_config_parity_release #2074

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

kislaykishore
Copy link
Collaborator

Description

Syncing master changes into CLI_config_parity_release

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

sethiay and others added 3 commits June 27, 2024 15:03
* Setting defaults for pd

* Updating defaults in config yaml
* adding new flag set in implicit dir package for hns

* delete implicit dir fix

* small fix

* testing

* exit code fix test

* fix hns tests

* fix hns tests

* testing delete folder with implicit dir

* lint fix

* review comments

* adding logger

* rebasing

* small fix

* review comments

* lint tests

* rebasing

* review comment

* small fix

* adding prefix bucket test

* test failure for delete folder

* test failure for delete folder

* test failure for delete folder

* lint fix

* adding todo

* adding implicit dir flag

* review comment

* review comments

* review comments

* lint fix

* lint fix

* reformating

* adding comment

* review comment

* undo unnecessary changes
@kislaykishore kislaykishore requested a review from a team as a code owner June 28, 2024 04:07
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (b8aa8dc) to head (3995bfb).
Report is 5 commits behind head on CLI_config_parity_release.

Files Patch % Lines
internal/fs/inode/dir.go 58.33% 4 Missing and 1 partial ⚠️
cfg/config.go 0.00% 3 Missing ⚠️
internal/cache/file/cache_handler.go 33.33% 2 Missing ⚠️
internal/cache/util/util.go 75.00% 1 Missing and 1 partial ⚠️
internal/cache/file/downloader/job.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           CLI_config_parity_release    #2074      +/-   ##
=============================================================
- Coverage                      72.34%   71.98%   -0.37%     
=============================================================
  Files                            100      100              
  Lines                          11028    11207     +179     
=============================================================
+ Hits                            7978     8067      +89     
- Misses                          2715     2806      +91     
+ Partials                         335      334       -1     
Flag Coverage Δ
unittests 71.98% <59.37%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore merged commit 01d07d4 into CLI_config_parity_release Jun 28, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants