Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-on-gke part 3] Accidentally closed PR.. reopened at PR#2359 #2319

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Aug 8, 2024

Description

Support special cases

  • Support instance_id
    1. Support env variable instance_id in run-script and in the python scripts (this allows multiple users to run the same tests using the same input/output bucket(s) without overwriting each others's outputs).
  • Support multiple combinations of blockSize,numThreads,filesPerThread combinations for a given fileSize for fio tests, in the same run without overwriting each other.

This follows right after #2272 .

This is followed up in #2322 and in #2329 .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle changed the base branch from master to garnitin/add-gke-load-testing/add-run-script/v1 August 8, 2024 13:58
@gargnitingoogle gargnitingoogle marked this pull request as ready for review August 8, 2024 13:58
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners August 8, 2024 13:58
@gargnitingoogle gargnitingoogle requested review from charith87 and removed request for a team August 8, 2024 13:58
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (garnitin/add-gke-load-testing/add-run-script/v1@790af9b). Learn more about missing BASE report.

Files Patch % Lines
cfg/types.go 0.00% 2 Missing ⚠️
cmd/legacy_main.go 0.00% 1 Missing ⚠️
internal/fs/fs.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                Coverage Diff                                 @@
##             garnitin/add-gke-load-testing/add-run-script/v1    #2319   +/-   ##
==================================================================================
  Coverage                                                   ?   79.10%           
==================================================================================
  Files                                                      ?      105           
  Lines                                                      ?    11619           
  Branches                                                   ?        0           
==================================================================================
  Hits                                                       ?     9191           
  Misses                                                     ?     1969           
  Partials                                                   ?      459           
Flag Coverage Δ
unittests 79.10% <55.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from e4b9816 to 68cb86f Compare August 8, 2024 15:39
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch 2 times, most recently from 0afbaba to df1d830 Compare August 8, 2024 20:29
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 3.1] Support special cases [testing-on-gke part 3] Support special cases Aug 8, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch 3 times, most recently from 34a2692 to 4a9a28b Compare August 9, 2024 15:24
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from df1d830 to f93aa87 Compare August 9, 2024 15:33
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from 4a9a28b to a3f31fe Compare August 9, 2024 16:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from f93aa87 to fdfc07a Compare August 12, 2024 04:21
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from a3f31fe to f5642c9 Compare August 12, 2024 06:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from fdfc07a to 2d7028e Compare August 12, 2024 06:37
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 3] Support special cases [testing-on-gke part 3] Support Support instance-id and more complex configuration combinations Aug 14, 2024
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 3] Support Support instance-id and more complex configuration combinations [testing-on-gke part 3] Support instance-id and more complex configuration combinations Aug 14, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/add-run-script/v1 branch from f5642c9 to 851fd80 Compare August 14, 2024 10:48
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/support-special-cases/v1 branch from 2eadd4b to e245d62 Compare August 14, 2024 10:48
@gargnitingoogle
Copy link
Collaborator Author

I closed this PR accidentally while pushing to the destination branch. I have reopened it in #2359 .

@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 3] Support instance-id and more complex configuration combinations [testing-on-gke part 3] Accidentally closed PR.. reopened at PR#2359 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants