Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rename metrics for non nested scenario for hns bucket #2339

Merged
merged 17 commits into from
Aug 23, 2024

Conversation

anushka567
Copy link
Member

Description

Added _run_rename_function which gets rename metrics for non nested scenario for hns bucket as well as flat bucket.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - here
  3. Integration tests - NA

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (4d5a56b) to head (f486ed9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2339      +/-   ##
==========================================
- Coverage   79.07%   79.04%   -0.04%     
==========================================
  Files         105      105              
  Lines       11577    11577              
==========================================
- Hits         9155     9151       -4     
- Misses       1958     1961       +3     
- Partials      464      465       +1     
Flag Coverage Δ
unittests 79.04% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anushka567 anushka567 force-pushed the hns-rename-benchmark-6 branch from 288a014 to beab71d Compare August 12, 2024 13:19
@anushka567 anushka567 marked this pull request as ready for review August 12, 2024 13:21
@anushka567 anushka567 requested review from Tulsishah and a team as code owners August 12, 2024 13:21
@kislaykishore kislaykishore requested review from a team and gargnitingoogle and removed request for a team August 12, 2024 13:22
@anushka567 anushka567 force-pushed the hns-rename-benchmark-6 branch from beab71d to f487070 Compare August 16, 2024 11:14
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment from Tulsishah Aug 19, 2024
@anushka567 anushka567 force-pushed the hns-rename-benchmark-6 branch 3 times, most recently from d8f05fb to 6268626 Compare August 20, 2024 12:56
@anushka567 anushka567 requested a review from Tulsishah August 22, 2024 06:11
@anushka567 anushka567 force-pushed the hns-rename-benchmark-6 branch from 0d4295d to b6d7aff Compare August 22, 2024 06:17
@anushka567 anushka567 force-pushed the hns-rename-benchmark-6 branch 2 times, most recently from 00484ae to cad6265 Compare August 22, 2024 07:24
@anushka567 anushka567 requested a review from Tulsishah August 22, 2024 08:34
@anushka567 anushka567 force-pushed the hns-rename-benchmark-6 branch from cad6265 to c117d32 Compare August 22, 2024 10:51
Tulsishah
Tulsishah previously approved these changes Aug 22, 2024
@anushka567 anushka567 merged commit 8288d45 into master Aug 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants