-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rename metrics for non nested scenario for hns bucket #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2339 +/- ##
==========================================
- Coverage 79.07% 79.04% -0.04%
==========================================
Files 105 105
Lines 11577 11577
==========================================
- Hits 9155 9151 -4
- Misses 1958 1961 +3
- Partials 464 465 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anushka567
force-pushed
the
hns-rename-benchmark-6
branch
from
August 12, 2024 13:19
288a014
to
beab71d
Compare
kislaykishore
requested review from
a team and
gargnitingoogle
and removed request for
a team
August 12, 2024 13:22
anushka567
force-pushed
the
hns-rename-benchmark-6
branch
from
August 16, 2024 11:14
beab71d
to
f487070
Compare
anushka567
force-pushed
the
hns-rename-benchmark-6
branch
3 times, most recently
from
August 20, 2024 12:56
d8f05fb
to
6268626
Compare
Tulsishah
reviewed
Aug 22, 2024
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
Tulsishah
reviewed
Aug 22, 2024
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
anushka567
force-pushed
the
hns-rename-benchmark-6
branch
from
August 22, 2024 06:17
0d4295d
to
b6d7aff
Compare
Tulsishah
reviewed
Aug 22, 2024
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
Tulsishah
reviewed
Aug 22, 2024
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark.py
Outdated
Show resolved
Hide resolved
anushka567
force-pushed
the
hns-rename-benchmark-6
branch
2 times, most recently
from
August 22, 2024 07:24
00484ae
to
cad6265
Compare
anushka567
force-pushed
the
hns-rename-benchmark-6
branch
from
August 22, 2024 10:51
cad6265
to
c117d32
Compare
Tulsishah
previously approved these changes
Aug 22, 2024
anushka567
force-pushed
the
hns-rename-benchmark-6
branch
from
August 23, 2024 05:10
c117d32
to
f486ed9
Compare
ankitaluthra1
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added _run_rename_function which gets rename metrics for non nested scenario for hns bucket as well as flat bucket.
Link to the issue in case of a bug fix.
NA
Testing details