-
Notifications
You must be signed in to change notification settings - Fork 459
Collecting rename metrics for nested folders #2370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2370 +/- ##
==========================================
- Coverage 79.07% 79.04% -0.03%
==========================================
Files 106 106
Lines 11578 11578
==========================================
- Hits 9155 9152 -3
- Misses 1956 1958 +2
- Partials 467 468 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
00484ae
to
cad6265
Compare
1a610f6
to
d53a461
Compare
c117d32
to
f486ed9
Compare
d53a461
to
d2e3780
Compare
d2e3780
to
57b638a
Compare
c473ef2
to
5ba3979
Compare
5ba3979
to
2ff0c40
Compare
Tulsishah
reviewed
Sep 3, 2024
Tulsishah
reviewed
Sep 3, 2024
perfmetrics/scripts/hns_rename_folders_metrics/renaming_benchmark_test.py
Show resolved
Hide resolved
d47bbe4
to
9ed0fcb
Compare
Tulsishah
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made changes to existing functions to collected and accumulate metrics for nested folders as well.Previously, we had code which collected metrics related to rename operation for single level folders i.e.
Thus, metrics reported for these folders were in the form of average/min/max etc. time taken for each folder level rename operation.
Since, hns atomic rename is especially crucial in nested folder rename scenario , hence we do perf tests on simple nested scenario i.e.
Here we report the time of rename operation for renaming top_level_folder to top_level_folder_renamed so that we can observe performance comparison in cases where implicit-dirs are involved.
Link to the issue in case of a bug fix.
NA
Testing details