Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing-on-gke part 6.5] Move code to access bucket iam role to backend #2496

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Sep 17, 2024

Description

This change moves the logic for adding read/write permission for data buckets for the tests for the kubernetes service account, from the shell script to the python backend library. This is for being accurate for the target buckets (which should be parsed from the JSON-based workload configuration) which is not trivial in a shell script, and also for better maintainability, testability etc.

Source request: #2329 (comment) (#2359 )

This is on top of #2482 and is followed up in #2497 .

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from bf2eac8 to 858df9d Compare September 17, 2024 07:10
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch 2 times, most recently from ddcef98 to d0e876b Compare September 17, 2024 10:18
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from e9904e0 to 1203353 Compare September 17, 2024 10:30
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from d0e876b to d7efbe5 Compare September 17, 2024 10:30
@gargnitingoogle gargnitingoogle marked this pull request as ready for review September 17, 2024 10:37
@gargnitingoogle gargnitingoogle requested review from Tulsishah and a team as code owners September 17, 2024 10:37
@gargnitingoogle gargnitingoogle requested review from sethiay and removed request for a team September 17, 2024 10:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 1203353 to fc374e8 Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from d7efbe5 to 809174f Compare September 18, 2024 06:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from fc374e8 to b8b5c7f Compare September 18, 2024 06:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 809174f to abbefaf Compare September 18, 2024 06:53
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from b8b5c7f to 5e20671 Compare September 18, 2024 08:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from abbefaf to ebf4a2a Compare September 18, 2024 08:17
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 5e20671 to e94975f Compare September 18, 2024 08:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from ebf4a2a to aa43846 Compare September 18, 2024 08:27
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from e94975f to 254c03c Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from aa43846 to 0b48a2d Compare September 18, 2024 08:41
@gargnitingoogle gargnitingoogle changed the title [testing-on-gke part 6.4] Move code to access bucket iam role to backend [testing-on-gke part 6.5] Move code to access bucket iam role to backend Sep 18, 2024
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 254c03c to 5d3e38d Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 0b48a2d to 35420e2 Compare September 18, 2024 08:55
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/monitoring-api-for-gce-vm branch from 5d3e38d to 55d10d9 Compare September 18, 2024 17:19
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 82a99cf to 899e938 Compare September 27, 2024 04:59
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from c7ea93e to a951192 Compare September 27, 2024 06:12
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 899e938 to 1c6ef8b Compare September 27, 2024 06:12
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from a951192 to ec97a13 Compare September 27, 2024 07:52
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 1c6ef8b to ab210db Compare September 27, 2024 07:52
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from ec97a13 to 545996a Compare September 27, 2024 09:31
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from ab210db to fbbfcbf Compare September 27, 2024 09:31
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 545996a to f1ab9e0 Compare September 27, 2024 09:44
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from fbbfcbf to 40ae805 Compare September 27, 2024 09:44
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from f1ab9e0 to 1849983 Compare September 27, 2024 12:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 40ae805 to ff95544 Compare September 27, 2024 12:45
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/fix-for-gce-vm-v1 branch from 1849983 to 4d15967 Compare September 27, 2024 13:37
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch 2 times, most recently from 6c1d84e to edff1de Compare September 27, 2024 14:59
@gargnitingoogle gargnitingoogle changed the base branch from garnitin/add-gke-load-testing/fix-for-gce-vm-v1 to master September 27, 2024 15:25
@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from edff1de to cf2deda Compare September 30, 2024 04:42
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (327d72e) to head (967c68d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2496      +/-   ##
==========================================
- Coverage   78.31%   78.28%   -0.04%     
==========================================
  Files         107      107              
  Lines       11770    11770              
==========================================
- Hits         9218     9214       -4     
- Misses       2069     2071       +2     
- Partials      483      485       +2     
Flag Coverage Δ
unittests 78.28% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from cf2deda to 1e5f648 Compare September 30, 2024 05:05
@kislaykishore
Copy link
Collaborator

kislaykishore commented Oct 1, 2024

Could you add some details in the description on why this change is needed?

@gargnitingoogle gargnitingoogle force-pushed the garnitin/add-gke-load-testing/move-iam-config-to-backend branch from 1e5f648 to 91b686e Compare October 2, 2024 23:35
@gargnitingoogle
Copy link
Collaborator Author

Could you add some details in the description on why this change is needed?

Done

@kislaykishore kislaykishore requested a review from a team October 3, 2024 00:19
@gargnitingoogle gargnitingoogle merged commit fa63975 into master Oct 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants