-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing-on-gke part 6.5] Move code to access bucket iam role to backend #2496
[testing-on-gke part 6.5] Move code to access bucket iam role to backend #2496
Conversation
bf2eac8
to
858df9d
Compare
ddcef98
to
d0e876b
Compare
e9904e0
to
1203353
Compare
d0e876b
to
d7efbe5
Compare
1203353
to
fc374e8
Compare
d7efbe5
to
809174f
Compare
fc374e8
to
b8b5c7f
Compare
809174f
to
abbefaf
Compare
b8b5c7f
to
5e20671
Compare
abbefaf
to
ebf4a2a
Compare
5e20671
to
e94975f
Compare
ebf4a2a
to
aa43846
Compare
e94975f
to
254c03c
Compare
aa43846
to
0b48a2d
Compare
254c03c
to
5d3e38d
Compare
0b48a2d
to
35420e2
Compare
5d3e38d
to
55d10d9
Compare
82a99cf
to
899e938
Compare
c7ea93e
to
a951192
Compare
899e938
to
1c6ef8b
Compare
a951192
to
ec97a13
Compare
1c6ef8b
to
ab210db
Compare
ec97a13
to
545996a
Compare
ab210db
to
fbbfcbf
Compare
545996a
to
f1ab9e0
Compare
fbbfcbf
to
40ae805
Compare
f1ab9e0
to
1849983
Compare
40ae805
to
ff95544
Compare
1849983
to
4d15967
Compare
6c1d84e
to
edff1de
Compare
edff1de
to
cf2deda
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2496 +/- ##
==========================================
- Coverage 78.31% 78.28% -0.04%
==========================================
Files 107 107
Lines 11770 11770
==========================================
- Hits 9218 9214 -4
- Misses 2069 2071 +2
- Partials 483 485 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cf2deda
to
1e5f648
Compare
perfmetrics/scripts/testing_on_gke/examples/utils/run_tests_common.py
Outdated
Show resolved
Hide resolved
perfmetrics/scripts/testing_on_gke/examples/utils/run_tests_common.py
Outdated
Show resolved
Hide resolved
Could you add some details in the description on why this change is needed? |
1e5f648
to
91b686e
Compare
Done |
Description
This change moves the logic for adding read/write permission for data buckets for the tests for the kubernetes service account, from the shell script to the python backend library. This is for being accurate for the target buckets (which should be parsed from the JSON-based workload configuration) which is not trivial in a shell script, and also for better maintainability, testability etc.
Source request: #2329 (comment) (#2359 )
This is on top of #2482 and is followed up in #2497 .
Link to the issue in case of a bug fix.
NA
Testing details