Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added destroy method to free up the memory buffers #2839

Merged
merged 9 commits into from
Dec 27, 2024

Conversation

vadlakondaswetha
Copy link
Collaborator

@vadlakondaswetha vadlakondaswetha commented Dec 24, 2024

Description

Added destroy method which will clean up the memory buffers when bwh is unInitialized.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@vadlakondaswetha vadlakondaswetha requested a review from a team as a code owner December 24, 2024 12:21
@kislaykishore kislaykishore requested review from a team, tritone and BrennaEpp and removed request for a team and tritone December 24, 2024 12:21
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.04%. Comparing base (3946230) to head (5a365d6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/bufferedwrites/buffered_write_handler.go 60.00% 3 Missing and 1 partial ⚠️
internal/fs/inode/file.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2839      +/-   ##
==========================================
- Coverage   76.05%   76.04%   -0.01%     
==========================================
  Files         118      118              
  Lines       16456    16490      +34     
==========================================
+ Hits        12515    12540      +25     
- Misses       3412     3419       +7     
- Partials      529      531       +2     
Flag Coverage Δ
unittests 76.04% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashmeenkaur
ashmeenkaur previously approved these changes Dec 27, 2024
Copy link
Collaborator

@ashmeenkaur ashmeenkaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

internal/bufferedwrites/upload_handler_test.go Outdated Show resolved Hide resolved
internal/bufferedwrites/upload_handler_test.go Outdated Show resolved Hide resolved
internal/fs/handle/file.go Show resolved Hide resolved
internal/bufferedwrites/upload_handler_test.go Outdated Show resolved Hide resolved
@vadlakondaswetha vadlakondaswetha merged commit a0dc44e into master Dec 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants