Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move Object] Add rename file method in dir layer #2841

Merged
merged 8 commits into from
Dec 27, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Dec 26, 2024

Description

  • RenameFile function in dir.go file
  • Added unit tests for successful rename and source does not exist

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added
  3. Integration tests - NA

@Tulsishah Tulsishah marked this pull request as ready for review December 26, 2024 06:57
@Tulsishah Tulsishah requested a review from a team as a code owner December 26, 2024 06:57
@kislaykishore kislaykishore requested review from a team and vadlakondaswetha and removed request for vadlakondaswetha December 26, 2024 06:58
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (e7acf94) to head (ec48912).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/fs/inode/base_dir.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2841      +/-   ##
==========================================
+ Coverage   76.03%   76.11%   +0.08%     
==========================================
  Files         118      118              
  Lines       16429    16510      +81     
==========================================
+ Hits        12492    12567      +75     
- Misses       3409     3413       +4     
- Partials      528      530       +2     
Flag Coverage Δ
unittests 76.11% <85.71%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/fs/inode/dir.go Outdated Show resolved Hide resolved
internal/fs/inode/base_dir.go Outdated Show resolved Hide resolved
internal/fs/inode/dir.go Outdated Show resolved Hide resolved
internal/fs/inode/hns_dir_test.go Outdated Show resolved Hide resolved
internal/fs/inode/hns_dir_test.go Outdated Show resolved Hide resolved
@Tulsishah Tulsishah merged commit 92566ec into master Dec 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants