Mounting succeeds gcsbucket doesnot exist #779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadlakondaswetha
requested changes
Sep 1, 2022
| if typed, ok := err.(*googleapi.Error); ok { | ||
| switch typed.Code { | ||
| case http.StatusForbidden: | ||
| //if typed, ok := err.(*googleapi.Error); ok { |
There was a problem hiding this comment.
please dont raise cls with commented code.
| //} | ||
|
|
||
| if err != nil { | ||
| if strings.Contains(err.Error(), "Error 403") { |
There was a problem hiding this comment.
as discussed please dont use string comparision for error. cast it appropriately like this and compare the status code.
(err.(*fmt.wrapError).err).(*googleapi.Error).Code
There was a problem hiding this comment.
Also check if we can cast error as mentioned in the link Prince shared: jacobsa/gcloud#15
| @@ -20,15 +20,16 @@ import ( | |||
| "log" | |||
| "net/http" | |||
| "net/url" | |||
| "strings" | |||
|
Just for the information, this bug is similar to the issue open in the gcloud codebase: jacobsa/gcloud#15 |
|
raise the same PR on jacobsa/gcloud repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to solve an error Mounting succeeds even if gcs call fails.