Skip to content

resolve critical syntax errors, undefined variables, and workspace configuration issues#2577

Open
Volgat wants to merge 7 commits intoGoogleCloudPlatform:mainfrom
Volgat:main
Open

resolve critical syntax errors, undefined variables, and workspace configuration issues#2577
Volgat wants to merge 7 commits intoGoogleCloudPlatform:mainfrom
Volgat:main

Conversation

@Volgat
Copy link

@Volgat Volgat commented Jan 8, 2026

This pull request addresses several critical bugs, syntax errors, and compatibility issues identified through static analysis and local testing across multiple components of the repository.

Summary of changes:

  1. Python Syntax and Version Compatibility
  • Refactored Literal type annotations in router.py to remove Python 3.11+ star expressions, ensuring compatibility with Python 3.10.
  • Downgraded Python 3.12 generic type parameter syntax in schemas.py to standard TypeVar and Generic definitions.
  • Updated the root .ruff.toml target-version to py311 to align with project-wide usage of asyncio.TaskGroup and ExceptionGroups.
  1. Resolution of Undefined Variable Errors
  • Added proper logger initialization in vertex_rag_demo_dual_llms_with_judge.py.
  • Added missing ValidationError import from pydantic in agent_05_ReportAgent.py.
  • Improved re.sub usage in RAG demo by using named arguments for count and flags.
  1. Photo Discovery App and Workspace Fixes
  • Created a stub firebase_options.dart file to resolve compilation errors in the Flutter sample app.
  • Corrected a recursive lib/ ignore rule in the root .gitignore that was incorrectly blocking access to subproject source code.

These changes ensure that the affected modules compile and run correctly in their intended environments.

@Volgat Volgat requested a review from a team as a code owner January 8, 2026 01:07
@google-cla
Copy link

google-cla bot commented Jan 8, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These probably don't need to be added. The spell-checker should already handle these terms

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holtskinner Good point removed those entries. Thanks!

@Volgat
Copy link
Author

Volgat commented Jan 31, 2026

@holtskinner The CLA is now signed ✅. Could you please take another look when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants