Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model training guide #1406

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

ganochenkodg
Copy link
Contributor

TF, yaml and python code for Model training guide

Copy link

snippet-bot bot commented Aug 13, 2024

Here is the summary of changes.

You are about to add 14 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull-request, @ganochenkodg!
Overall, looking good. I'm guessing this is still work-in-progress?
Let me know when you're ready to merge. :)

I left some comments.

@@ -0,0 +1,32 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Looks like we'll need Copyright 2024 Google LLC Apache license headers for most of these files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

}

# [START gke_model_train_standard_private_regional_cluster]
module "training_cluster" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Will the Terraform (from the repo) be embedded in the tutorial as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "embedded"? In the guide we run "git clone" and "terraform apply" with this code

image: quay.io/jupyter/pytorch-notebook:cuda11-python-3.11
#image: tensorflow/tensorflow:2.17.0-gpu-jupyter
#command: [ "/bin/bash", "-c", "--" ]
#args: [ "while true; do sleep 30; done;" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is this (chunk of commented-out code) intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest: Judging from the requirements listed here, we'll need a README.md file for the ai-ml/model-train folder. Could you please add a README.md file with a link to the cloud.google.com tutorial where these samples will be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, but link is empty, we don't know it until guide is published

@NimJay NimJay marked this pull request as draft August 23, 2024 15:51
@ganochenkodg ganochenkodg marked this pull request as ready for review September 12, 2024 16:53
@ganochenkodg
Copy link
Contributor Author

@NimJay thank you for all your comments, we will try to fix them soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants