Add test for updating persistent disk size and disk type in cloud workstations by joelkattapuram · Pull Request #12910 · GoogleCloudPlatform/magic-modules

joelkattapuram · 2025-01-29T17:13:22Z

Release Note Template for Downstream PRs (will be copied)

Add test for updating persistent disk size and disk type for cloud workstations configs.

github-actions · 2025-01-29T17:14:15Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

…udPlatform#12872)

modular-magician · 2025-01-29T17:23:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 79 insertions(+))

modular-magician · 2025-01-29T17:26:37Z

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

modular-magician · 2025-01-29T17:57:18Z

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…s into updatePdTest

…to Cluster_Disabled (GoogleCloudPlatform#12761) Co-authored-by: asatyarth <asatyarth@google.com>

modular-magician · 2025-01-29T21:34:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 122 insertions(+))

modular-magician · 2025-01-29T21:37:15Z

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

modular-magician · 2025-01-29T21:37:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 81 insertions(+))

modular-magician · 2025-01-29T21:40:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 1 file changed, 81 insertions(+))

modular-magician · 2025-01-29T21:40:39Z

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

modular-magician · 2025-01-29T21:42:57Z

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

modular-magician · 2025-01-29T22:13:48Z

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-29T22:14:28Z

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-29T22:19:38Z

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…rm#12915)

hao-nan-li

I think you can add the labels field into ImportStateVerifyIgnore

… on the IGM (GoogleCloudPlatform#12864)

…oudPlatform#12985)

modular-magician · 2025-02-08T00:12:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 84 insertions(+), 2 deletions(-))

modular-magician · 2025-02-08T00:15:59Z

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

workstations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_updatePersistentDirectory

Get to know how VCR tests work

modular-magician · 2025-02-08T00:32:55Z

🔴 Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_updatePersistentDirectory [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…dPlatform#12832)

…latform#12982)

…rm#12963) Signed-off-by: Cezary Sobczak <Cezary.Sobczak@infogain.com>

…rm#12991)

…gion (GoogleCloudPlatform#13027) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

…eCloudPlatform#12955) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

…orm#12895) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

GoogleCloudPlatform#13016)

…loudPlatform#13017)

…s into updatePdTest

modular-magician · 2025-02-11T18:43:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 129 insertions(+), 2 deletions(-))

add test to allow updating pd size and pd disk type

b11614a

joelkattapuram changed the title ~~Add test to allow updating pd size and pd disk type~~ Add test to allow updating persistent disk size and disk type Jan 29, 2025

github-actions bot requested a review from hao-nan-li January 29, 2025 17:14

joelkattapuram changed the title ~~Add test to allow updating persistent disk size and disk type~~ Add test for updating persistent disk size and disk type in cloud workstations Jan 29, 2025

Adding API Docs for google_workbench_instance for registry (GoogleClo…

75ef317

…udPlatform#12872)

modular-magician added the service/workstations label Jan 29, 2025

joelkattapuram and others added 7 commits January 29, 2025 21:24

add test to allow updating pd size and pd disk type

67ce2c7

Add support for diffing field sets (GoogleCloudPlatform#12330)

0e9d4ce

Merge branch 'updatePdTest' of github.com:joelkattapuram/magic-module…

ad3ac4d

…s into updatePdTest

Merge branch 'updatePdTest' of github.com:joelkattapuram/magic-module…

e9e5836

…s into updatePdTest

Merge branch 'updatePdTest' of github.com:joelkattapuram/magic-module…

f506dcf

…s into updatePdTest

Memorystore Cluster_Disabled : Rename Standalone value in Mode field …

67558a9

…to Cluster_Disabled (GoogleCloudPlatform#12761) Co-authored-by: asatyarth <asatyarth@google.com>

fix

5d7d17e

Add Security Gateway Application resource (GoogleCloudPlatform#12837)

ff7f731

Revert "Add Security Gateway Application resource" (GoogleCloudPlatfo…

b07ab16

…rm#12915)

hao-nan-li reviewed Jan 30, 2025

View reviewed changes

Allow parallelization of per instance config deletions by not locking…

2cabee5

… on the IGM (GoogleCloudPlatform#12864)

joelkattapuram and others added 2 commits February 8, 2025 00:01

fix spacing

52d74e5

Add support for new flags in Container node_kubelet_config. (GoogleCl…

68ab860

…oudPlatform#12985)

rileykarson and others added 23 commits February 10, 2025 17:48

Fix IAM Policy Datasource header (GoogleCloudPlatform#12973)

5eb5698

Migrate google_eventarc_trigger resource from DCL to MMv1 (GoogleClou…

80eaa7b

…dPlatform#12832)

fix missing alias for name secret_ref (hashicorp#21272) (GoogleCloudP…

5646713

…latform#12982)

Feature gap: add gracefulShutdown field for beta (GoogleCloudPlatfo…

a494af4

…rm#12963) Signed-off-by: Cezary Sobczak <Cezary.Sobczak@infogain.com>

Fixed error message when naming disks (GoogleCloudPlatform#12981)

366c857

Add location field to google_network_services_mesh (GoogleCloudPlatfo…

08ecbc9

…rm#12991)

add fix for bbdc private tests (GoogleCloudPlatform#13028)

4e3c975

Fix instances where no items found in region by continuing to next re…

2fa88b2

…gion (GoogleCloudPlatform#13027) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update cluster versions in TestAccContainerNodePool_concurrent (Googl…

15b9d38

…eCloudPlatform#12955) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Add Gemini Release Channel Setting Binding resource (GoogleCloudPlatf…

509063e

…orm#12895) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Update enrolled_teams.yml (GoogleCloudPlatform#13008)

9b3c47f

Change description of Gemini Data Sharing With Google Setting Resource (

c8d4352

GoogleCloudPlatform#13016)

Change description of Gemini Gcp Enablement Setting Resource (GoogleC…

09e909c

…loudPlatform#13017)

added bbasata as a trusted contributor (GoogleCloudPlatform#13041)

9e67074

fix formatting

6558032

add test to allow updating pd size and pd disk type

6a1306f

add test to allow updating pd size and pd disk type

ad35930

fix

5902728

ignore labels field

eb76f37

remove immutable tag

a8664cc

fix spacing

afd7216

fix formatting

61fc5e0

Merge branch 'updatePdTest' of github.com:joelkattapuram/magic-module…

b35f3d9

…s into updatePdTest

joelkattapuram closed this Feb 11, 2025

Conversation

joelkattapuram commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

modular-magician commented Jan 29, 2025

Diff report

Uh oh!

modular-magician commented Jan 29, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 29, 2025

Uh oh!

modular-magician commented Jan 29, 2025

Diff report

Uh oh!

modular-magician commented Jan 29, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 29, 2025

Diff report

Uh oh!

modular-magician commented Jan 29, 2025

Diff report

Uh oh!

modular-magician commented Jan 29, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 29, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 29, 2025

Uh oh!

modular-magician commented Jan 29, 2025

Uh oh!

modular-magician commented Jan 29, 2025

Uh oh!

hao-nan-li left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Feb 8, 2025

Diff report

Uh oh!

modular-magician commented Feb 8, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 8, 2025

Uh oh!

modular-magician commented Feb 11, 2025

Diff report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

joelkattapuram commented Jan 29, 2025 •

edited

Loading