Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Post sart up script on runtime templates #12929

Merged
merged 18 commits into from
Feb 1, 2025

Conversation

bcreddy-gcp
Copy link
Contributor

@bcreddy-gcp bcreddy-gcp commented Jan 31, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

colab: added `software_config.post_startup_script_config` field to `google_colab_runtime_template`

@github-actions github-actions bot requested a review from trodge January 31, 2025 00:55
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 326 insertions(+))
google-beta provider: Diff ( 4 files changed, 326 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 114 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 13 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 10
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • colab

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccColabRuntimeTemplate_colabRuntimeTemplateFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@trodge trodge added this pull request to the merge queue Feb 1, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 0500297 Feb 1, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants