Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for baseImageUri and buildInfo in Cloud Run V2 Service.template.containers #12938

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

akerekes
Copy link
Contributor

@akerekes akerekes commented Jan 31, 2025

This PR also fixes the update tests for Cloud Run functions by moving the test code from mmv1/third_party/terraform/services/cloudrunv2/resource_cloud_run_v2_service_test.go to mmv1/third_party/terraform/services/cloudrunv2/resource_cloud_run_v2_service_test.go.tmpl

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudrunv2: added `base_image_uri` and `build_info` to `google_cloud_run_v2_service`

@akerekes akerekes marked this pull request as ready for review January 31, 2025 22:29
@github-actions github-actions bot requested a review from BBBmau January 31, 2025 22:30
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 302 insertions(+))
google-beta provider: Diff ( 5 files changed, 302 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 44
Skipped tests: 5
Affected tests: 2

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample
  • TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample [Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFunctionExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

mmv1/products/cloudrunv2/Service.yaml Outdated Show resolved Hide resolved
Removed unnecessary emphasis on the field being supported only for services.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 302 insertions(+))
google-beta provider: Diff ( 5 files changed, 302 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 46
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

🟢 All tests passed!

View the build log

@akerekes
Copy link
Contributor Author

akerekes commented Feb 4, 2025

@BBBmau PTAL

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BBBmau I was pinged on this internally that there was some urgency with this change, so I went ahead and reviewed to get it in before the release cutoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants