apigee: fix org_id doubled prefix in google_apigee_sharedflow#16947
Open
xuchenma wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
apigee: fix org_id doubled prefix in google_apigee_sharedflow#16947xuchenma wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
xuchenma wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
When users reference google_apigee_organization.id as org_id, the value already contains the 'organizations/' prefix (e.g. 'organizations/my-project'). The URL template then doubles it to 'organizations/organizations/my-project', causing API 404 errors. Fix by adding a StateFunc and DiffSuppressFunc to the org_id field that strip the 'organizations/' prefix if present, allowing both bare project IDs and fully-qualified organization IDs to be used interchangeably. Fixes: hashicorp/terraform-provider-google#25876
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where using
google_apigee_organization.idasorg_idingoogle_apigee_sharedflowcaused a doubledorganizations/prefix in the API URL, resulting in 404 errors.google_apigee_organization.idreturns"organizations/<project-id>". The resource URL template isorganizations/{{org_id}}/sharedflows, so when the full value is substituted it becomesorganizations/organizations/<project-id>/sharedflows.Fix: Added a
StateFuncandDiffSuppressFuncto theorg_idfield that strip theorganizations/prefix if present, so both bare project IDs and fully-qualified organization IDs work correctly.Fixes: hashicorp/terraform-provider-google#25876
Tests
TestAccApigeeSharedFlow_apigeeSharedflowTestExamplepassed locally (1138s):