apigee: fix import format docs for google_apigee_addons_config (org not name)#16950
Open
xuchenma wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
apigee: fix import format docs for google_apigee_addons_config (org not name)#16950xuchenma wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
xuchenma wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: hashicorp/terraform-provider-google#14607
The generated documentation for
google_apigee_addons_configshowed{{name}}as the import identifier field, but the actual field is named{{org}}. This caused the import instructions in the docs to be incorrect.Root cause:
AddonsConfig.yamlhad noimport_formatsection. Without it, the code generator fell back to a default that used{{name}}, which is not a field on this resource. The correct field is{{org}}.Fix: Added
import_formattoAddonsConfig.yamlexplicitly specifyingorganizations/{{org}}and{{org}}.Test evidence
TestAccApigeeAddonsConfig_apigeeAddonsTestExamplepassed locally (1377s):