Skip to content

apigee: fix import format docs for google_apigee_addons_config (org not name)#16950

Open
xuchenma wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
xuchenma:284515593
Open

apigee: fix import format docs for google_apigee_addons_config (org not name)#16950
xuchenma wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
xuchenma:284515593

Conversation

@xuchenma
Copy link
Copy Markdown
Contributor

@xuchenma xuchenma commented Apr 4, 2026

Summary

Fixes: hashicorp/terraform-provider-google#14607

The generated documentation for google_apigee_addons_config showed {{name}} as the import identifier field, but the actual field is named {{org}}. This caused the import instructions in the docs to be incorrect.

Root cause: AddonsConfig.yaml had no import_format section. Without it, the code generator fell back to a default that used {{name}}, which is not a field on this resource. The correct field is {{org}}.

Fix: Added import_format to AddonsConfig.yaml explicitly specifying organizations/{{org}} and {{org}}.

Test evidence

TestAccApigeeAddonsConfig_apigeeAddonsTestExample passed locally (1377s):

--- PASS: TestAccApigeeAddonsConfig_apigeeAddonsTestExample (1377.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google/services/apigee	1378.010s
apigee: fixed `google_apigee_addons_config` import documentation to use correct field name `org` instead of `name`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn April 4, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation bug: Import formats for google_apigee_addons_config contain non-existent fields

2 participants