apigee: add Example Usage sections to google_apigee_sharedflow documentation#16966
Open
xuchenma wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Open
apigee: add Example Usage sections to google_apigee_sharedflow documentation#16966xuchenma wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
xuchenma wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
The isEnabled field on TargetServer used the standard IsEmptyValue guard which treats boolean false as an empty value. This meant setting is_enabled = false had no effect: the API defaulted to true. Fix: add send_empty_value: true to the isEnabled field in TargetServer.yaml so the generated code always includes the field in create and update requests regardless of its value. Also adds acceptance test TestAccApigeeTargetServer_apigeeTargetServerIsEnabledFalse that creates a target server with is_enabled=false, verifies it is actually disabled, then updates it to true.
…tation The google_apigee_sharedflow resource page was missing an Example Usage section, making it harder for users to understand how to use the resource. This was reported in GitHub issue GoogleCloudPlatform#14144. Changes: - Add "Apigee Sharedflow Basic" example showing the minimal config using data.archive_file for the bundle (mirrors google_apigee_api docs style) - Add "Apigee Sharedflow With Organization" example showing a complete setup including the required Apigee organization, networking, and service enablement - Fix page title: google_apigee_shared_flow -> google_apigee_sharedflow - Fix meta_data descriptions: "API proxy" -> "shared flow" (copy-paste error) Fixes: hashicorp/terraform-provider-google#14144 BUG=280337412
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
google_apigee_sharedflowdocumentation page had no Example Usage section,making it harder for users to understand how to use the resource. Also fixed two
pre-existing issues on the same page:
google_apigee_shared_flow(with underscore) — correctedto
google_apigee_sharedflow.meta_datafield descriptions referred to "API proxy" — corrected to"shared flow".
Change
mmv1/third_party/terraform/website/docs/r/apigee_sharedflow.html.markdown:detect_md5hashandmeta_data)meta_datadescription copy-paste errorTesting
Documentation-only change; no acceptance test required.
Fixes: b/280337412