Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GoB repo cloning mechanism #484

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Add GoB repo cloning mechanism #484

merged 9 commits into from
Nov 27, 2024

Conversation

gunjanj007
Copy link
Collaborator

Description

Changes:

Clone from GoB repo instead of GitHub for getting recipes by using git_cookie_authdaemon and using https googlesource link to copy.
General cleanup/refactor

Tests

Ran the test, it successfully deployed the cluster.

Instruction and/or command lines to reproduce your tests: trigger DAG

List links for your tests (use go/shortn-gen for any internal link): http://shortn/_iRgQ5rTdM8

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@polydier1 polydier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please address minor comments and then you can merge

dags/map_reproducibility/aotc_reproducibility.py Outdated Show resolved Hide resolved
dags/map_reproducibility/nemo_gpt3.py Show resolved Hide resolved
@gunjanj007 gunjanj007 merged commit e27c58a into master Nov 27, 2024
6 checks passed
@gunjanj007 gunjanj007 deleted the gj2 branch November 27, 2024 18:50
@gunjanj007 gunjanj007 restored the gj2 branch December 5, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants