Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Exist GPU Instance for Auotmation #538

Merged
merged 16 commits into from
Jan 16, 2025
Merged

Reuse Exist GPU Instance for Auotmation #538

merged 16 commits into from
Jan 16, 2025

Conversation

jyj0w0
Copy link
Collaborator

@jyj0w0 jyj0w0 commented Jan 10, 2025

Description

Add functions for reusing GPU instance.

Tests

https://screenshot.googleplex.com/3uLrquTpusRR2eH

Instruction and/or command lines to reproduce your tests: ...

List links for your tests (use go/shortn-gen for any internal link): ...

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few question.

xlml/apis/task.py Outdated Show resolved Hide resolved
dags/inference/configs/trt_llm_inference_config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the feature!

xlml/apis/task.py Outdated Show resolved Hide resolved
xlml/utils/metric.py Outdated Show resolved Hide resolved
xlml/apis/task.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM! Thanks!

xlml/apis/task.py Outdated Show resolved Hide resolved
xlml/apis/task.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ManfeiBai ManfeiBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jyj0w0 jyj0w0 merged commit 5d6ff02 into master Jan 16, 2025
6 checks passed
@jyj0w0 jyj0w0 deleted the yijiaj/a3u branch January 16, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants