Stingram/network issue fix #592
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, two slices of v5p-8. This is to ensure that both r2.6 and ptxla nightly continue to work in multi-slice (DCN networking involved) environments. I noticed that we are not testing llama3 in nightly so I added that too, copying from our release tests.
…ependencies (#583) * Run the vLLM TPU test in Docker * Use Half-width comma * Use "sudo docker exec $CONTAINER_NAME /bin/bash -c" * Add HF_TOKEN * Use a static VLLM_TPU_CONTAINER name * Remove unused argument * Try jq * use escape * Try \\" * escape the single quote * Try 5: escape of single quote + double escape of double quote * Try 6: double escape of double quote * Try 7: double quote for command inside container and escape of double quotes * Try 8 * Try 9: double escape of double quotes * Escape \n * Try \\\n * Try \\$ * Try \\\" * Get the GCS destination path *before* constructing the command. * Get the GCS destination path *before* constructing the command. OUTSIDE the list. * Add \" and debug information * passing GCS as an environment variable * pkill vllm * Address comments * Reformat using command "pre-commit run --files dags/solutions_team/configs/vllm/vllm_benchmark_config.py"
…use benchmark_runner.py (#590)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of relevant context/issue and your changes.
Tests
Please describe the tests that you ran on Cloud VM to verify changes.
Instruction and/or command lines to reproduce your tests: ...
List links for your tests (use go/shortn-gen for any internal link): ...
Checklist
Before submitting this PR, please make sure (put X in square brackets):