Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxtext nightly test on 1 slice of v4-8 #72

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

tonyjohnchen
Copy link
Collaborator

Description

Please include a summary of relevant context/issue and your changes.

Run maxtext nightly on 1 slice of v4-8

Tests

Please describe the tests that you ran on Cloud VM to verify changes.

Instruction and/or command lines to reproduce your tests: ...

List links for your tests (use go/shortn-gen for any internal link): ...

Test logs: https://screenshot.googleplex.com/KNCMu8sQyxeNXWs.png
Test result: https://screenshot.googleplex.com/7sXcqLTgiAKcXKc.png

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@RissyRan RissyRan requested review from jonb377 and RissyRan January 12, 2024 01:41
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, others look good to me. Thanks!

configs/maxtext/maxtext_gce_config.py Outdated Show resolved Hide resolved
@tonyjohnchen tonyjohnchen requested a review from RissyRan January 12, 2024 17:59
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RissyRan RissyRan merged commit 14ba06c into GoogleCloudPlatform:master Jan 12, 2024
5 checks passed
Copy link
Collaborator

@jonb377 jonb377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Tony!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants