-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maxtext nightly test on 1 slice of v4-8 #72
Add maxtext nightly test on 1 slice of v4-8 #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, others look good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Tony!
Description
Please include a summary of relevant context/issue and your changes.
Run maxtext nightly on 1 slice of v4-8
Tests
Please describe the tests that you ran on Cloud VM to verify changes.
Instruction and/or command lines to reproduce your tests: ...
List links for your tests (use go/shortn-gen for any internal link): ...
Test logs: https://screenshot.googleplex.com/KNCMu8sQyxeNXWs.png
Test result: https://screenshot.googleplex.com/7sXcqLTgiAKcXKc.png
Checklist
Before submitting this PR, please make sure (put X in square brackets):