Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable XLA_USE_BF16 for hf-llm tests #1046

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Enable XLA_USE_BF16 for hf-llm tests #1046

merged 1 commit into from
Feb 12, 2024

Conversation

bhavya01
Copy link
Collaborator

@bhavya01 bhavya01 commented Feb 10, 2024

Description

Please include a summary of relevant context/issue and your changes.

To fix the error INTERNAL: during context [pre-optimization]: Seen floating point types of different precisions in %add.832 = f32[8192,3072]{1,0} add(f32[8192,3072]{1,0} %dot.827, bf16[8192,3072]{1,0} %broadcast.831), but mixed precision is disallowed. while running hf-llm test.

Tests

Please describe the tests that you ran on TPUs to verify changes.

Instruction and/or command lines to reproduce your tests:

./scripts/format-jsonnet.sh
./scripts/gen-tests.sh
./scripts/run-oneshot.sh -t pt-2.2-hf-gpt2-2b-pjrt-conv-v4-8-1vm

List links for your tests (use go/shortn-gen for any internal link):
http://shortn/_H3YSIzI3oi

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@bhavya01 bhavya01 requested a review from yeounoh February 10, 2024 01:22
Copy link
Contributor

@yeounoh yeounoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeounoh
Copy link
Contributor

yeounoh commented Feb 12, 2024

Thank you @bhavya01

@will-cromar will-cromar merged commit 5dcf21f into master Feb 12, 2024
6 of 7 checks passed
@will-cromar will-cromar deleted the llm_tests branch February 12, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants