Skip to content

Conversation

holtskinner
Copy link
Contributor

Description

  • us-central1 became allowlist only for new projects

@holtskinner holtskinner requested review from a team as code owners September 26, 2025 15:29
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2025
Copy link
Contributor

Summary of Changes

Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the quickstart_example.py file to use us-east4 as the default region for Vertex AI initialization. This modification addresses an issue where us-central1 is no longer available by default for new projects, ensuring that users can successfully run the quickstart example without encountering region-related access restrictions.

Highlights

  • Default Region Update: The default Vertex AI initialization region in quickstart_example.py has been updated from us-central1 to us-east4.
  • Reason for Change: This change was necessary because us-central1 is now allowlist-only for new projects, which could prevent users from running the quickstart example.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the region from us-central1 to us-east4 in the quickstart example, addressing the new access restrictions on us-central1. However, the change appears to be incomplete as several other files in the generative_ai/rag/ directory still use the us-central1 region. To ensure all examples and tests function correctly for all users, I recommend extending this change to all relevant files. The files that still reference us-central1 include:

  • generative_ai/rag/test_rag_examples.py
  • generative_ai/rag/create_corpus_example.py
  • generative_ai/rag/generate_content_example.py
  • generative_ai/rag/retrieval_query_example.py

Updating these files as part of this PR will ensure consistency across the codebase.


# Initialize Vertex AI API once per session
vertexai.init(project=PROJECT_ID, location="us-central1")
vertexai.init(project=PROJECT_ID, location="us-east4")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and consistency with other files in this directory (like test_rag_examples.py), consider defining the location as a module-level constant (e.g., LOCATION = "us-east4") at the top of the file and using that constant here. This makes it easier to update the region in the future if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants