Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
REGISTRY?=gcr.io/k8s-minikube
VERSION=v0.1.3
VERSION=v0.1.4
GOOS?=$(shell go env GOOS)
GOARCH?=$(shell go env GOARCH)
ARCH=$(if $(findstring amd64, $(GOARCH)),x86_64,$(GOARCH))
KO_VERSION=0.16.0
KO_VERSION=0.18.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The KO_VERSION is being updated to 0.18.0, but this version does not appear to exist in the ko releases. This will cause the make image target to fail with a 404 error when trying to download the tool. The latest stable version seems to be 0.16.0. Please use a valid and existing version for ko.

KO_VERSION=0.16.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BASE_IMAGE?=gcr.io/distroless/static:nonroot

build: ## Build the gcp-auth-webhook binary
Expand All @@ -12,7 +12,7 @@ build: ## Build the gcp-auth-webhook binary
.PHONY: image
image: ## Create and push multiarch manifest and images
@read -p "This will build and push $(REGISTRY)/gcp-auth-webhook:$(VERSION). Do you want to proceed? (Y/N): " confirm && echo $$confirm | grep -iq "^[yY]" || exit 1;
curl -L https://github.com/google/ko/releases/download/v$(KO_VERSION)/ko_$(KO_VERSION)_$(GOOS)_$(ARCH).tar.gz | tar xzf - ko && chmod +x ./ko
curl -L https://github.com/ko-build/ko/releases/download/v$(KO_VERSION)/ko_$(KO_VERSION)_$(GOOS)_$(ARCH).tar.gz | tar xzf - ko && chmod +x ./ko
GOFLAGS="-ldflags=-X=main.Version=$(VERSION)" KO_DOCKER_REPO=$(REGISTRY) KO_DEFAULTBASEIMAGE=$(BASE_IMAGE) ./ko publish -B . --platform all -t $(VERSION)
rm ./ko

Expand Down
Loading