Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added take_an_l writeup #3

Merged
merged 5 commits into from
Sep 27, 2018
Merged

Added take_an_l writeup #3

merged 5 commits into from
Sep 27, 2018

Conversation

dshynkev
Copy link
Contributor

Since the C code is long here, unlike #1 and #2, this doesn't include the code inline in the README. For uniformity's sake, it might make sense to change this on #1 and #2's side.

@dshynkev dshynkev self-assigned this Sep 23, 2018
@dshynkev dshynkev requested a review from tyxchen September 23, 2018 13:40
@dshynkev dshynkev requested a review from JasonLiu84 September 23, 2018 13:48
Copy link

@tyxchen tyxchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a reader, I'd definitely prefer to see some diagrams on the recursive process (if possible). Aside from that and the one comment, it looks good to me.

- inductive step: if a `2^k x 2^k` square with a mark can be tiled,
we tile a `2^(k + 1) x 2^(k + 1)` square by splitting it into four
`2^k x 2^k` quadrants and tiling an L into quadrants which do not contain
a mark already so that each contains exactly one cell comprising the L.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording here is a bit confusing --- just saying "tiling an L with one cell in each quadrant" as in the comments would be clearer

@dshynkev
Copy link
Contributor Author

@tyxchen changed as directed 👍

@tyxchen
Copy link

tyxchen commented Sep 27, 2018

lgtm 👍

@dshynkev dshynkev removed the request for review from JasonLiu84 September 27, 2018 02:57
@dshynkev dshynkev merged commit 6ea6bb5 into GooseCTF:master Sep 27, 2018
@dshynkev dshynkev deleted the take_an_l branch September 27, 2018 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants