Open
Conversation
chernishev
reviewed
Nov 11, 2025
Collaborator
There was a problem hiding this comment.
- тут в PR не нужные файлы
- вот тут неправильное дерево (больше к сортировочной станции относится) https://github.com/Gosha924/hw/network --- Вам надо от ветки со стеком делать ветки, их из них PR; кстати, предполагалось что на каждое задание будет своя ветка от master
chernishev
reviewed
Nov 11, 2025
| { | ||
| const OBJ* current = top; | ||
| while (current != NULL) { | ||
| printf("%d\n", current->data); |
Collaborator
There was a problem hiding this comment.
по-хорошему библиотека не должна ни чего печатать
chernishev
reviewed
Nov 11, 2025
| if (string[i] == '[' || string[i] == ']') { | ||
| top = push(top, string[i]); | ||
| } | ||
| if (string[i] == '{' || string[i] == '}') { |
Collaborator
There was a problem hiding this comment.
надо бы убрать это раскопирование
chernishev
reviewed
Nov 11, 2025
| char string[100]; | ||
| printf("Введите строку: "); | ||
| fgets(string, sizeof(string), stdin); | ||
| OBJ* top = NULL; |
chernishev
reviewed
Nov 11, 2025
| for (int j = 0; j < lenStack(top) - 1; j++) { | ||
| int a = showElem(top, j); | ||
| int b = showElem(top, j + 1); | ||
| if (a - b < 3 && a - b > 0) { |
Collaborator
There was a problem hiding this comment.
тут не понятно что происходит, зачем вычитать?
chernishev
reviewed
Nov 11, 2025
| } else { | ||
| printf("Корректная скобочная последовательность\n"); | ||
| } | ||
| while (top != NULL) { |
Collaborator
There was a problem hiding this comment.
если это корректная скобочная последовательность, то этого делать не надо
chernishev
requested changes
Nov 11, 2025
Collaborator
chernishev
left a comment
chernishev
left a comment
There was a problem hiding this comment.
3/6, замечания в коде
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.