Merged
Conversation
Member
whitecity01
commented
Nov 15, 2025
whitecity01
commented
- 채팅 설정 get, put 요청 연동하였습니다.
- csrf 토큰 로직 삭제되어서 해당 기능을 제거했습니다.
|
Visit the preview URL for this PR (updated for commit 5010c4d): https://web-deploy-9d41a--pr63-feature-setting-8jmgrngv.web.app (expires Sun, 23 Nov 2025 13:13:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4a5d43964536093bf8932015bdd49b24c5b660ce |
sernan96
reviewed
Nov 16, 2025
Contributor
sernan96
left a comment
sernan96
left a comment
There was a problem hiding this comment.
상수화를 할 부분 외에는 딱히 문제가 없어 보입니다.
수고하셨습니다.
| getChatSetting(); | ||
| }, []); | ||
|
|
||
| const normalChatOptions = [ |
Member
Author
There was a problem hiding this comment.
채팅 설정이 확장 가능성도 적고 해당 파일에서만 다룬다고 생각해서, 따로 상수 파일을 만들어서 관리하는게 오히려 더 복잡하지 않을까요?
| { label: '모두 차단', value: 'DENY_ALL' }, | ||
| ]; | ||
|
|
||
| const whisperChatOptions = [ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.