Require reqwest feature rustls-tls-native-roots
#3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the system's trust roots, rather than those from WebPKI. This is important for enterprise users, where additional enterprise-specific roots may be defined on the system.
djmitche
commented
Sep 17, 2024
| @@ -10,6 +10,8 @@ crate-type = ["staticlib"] | |||
| [dependencies] | |||
| taskchampion = "0.7.0" | |||
| cxx = "1.0.124" | |||
| # Not used directly, but adds the native-roots feature. #3625. | |||
| reqwest = { version = ">= 0.11.27", default-features = false, features = ["rustls-tls-native-roots"] } | |||
There was a problem hiding this comment.
This "fake dependency" is probably not the best way to solve the issue. Probably, we should mirror this feature from taskchampion into reqwest (on which it depends). But this will do for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the system's trust roots, rather than those from WebPKI. This is important for enterprise users, where additional enterprise-specific roots may be defined on the system. See #3625.