Feature/light and vob misc #37
Conversation
This is used for getting the textures from pointers (lighmaps have pointers to textures)
The commented code are VObs that are not present in world.zen by default
|
|
||
| namespace PxCs.Data.Mesh | ||
| { | ||
| public class PxLightMapData |
There was a problem hiding this comment.
Is this a vob? I mean does it inherit from PxVobData?
If not, then it shouldn't be inside Vob namespace, I guess.
There was a problem hiding this comment.
This is in mesh namespace as it is used by meshes
There was a problem hiding this comment.
I believe you meant to comment to PxLightPresetData:
LightPreset is also defined under VOb in phoenix (now zenkit)
|
|
||
| namespace PxCs.Data.Vob | ||
| { | ||
| public class PxLightPresetData |
There was a problem hiding this comment.
Is this a vob? I mean does it inherit from PxVobData?
If not, then it shouldn't be inside Vob namespace, I guess.
There was a problem hiding this comment.
this is both a vob and a light, inside phoenix it is declared as such
struct Light : public VirtualObject, public LightPreset
There was a problem hiding this comment.
Light presets are not VObs but the have the same content as lights. Notice that LightPreset does not inherit from VirtualObject
| @@ -1,10 +1,81 @@ | |||
| using System; | |||
| using System.Numerics; | |||
|
|
|||
| namespace PxCs.Data.Vob | |||
| { | |||
| [Serializable] | |||
| public class PxVobNpcData : PxVobData | |||
There was a problem hiding this comment.
This is great. Will help us with future NPC stuff.
But this isn't a VOB, this is a VM entry.
- Please check
PxCs.Data.Vm.PxVmNpcDataand add your elements here. - Do you load this data already? Please do so if not.
- Please enlarge the existing PxVmTest to check a few on these
There was a problem hiding this comment.
Duh, you're totally right, my mistake
There was a problem hiding this comment.
|
I'm currently switching to ZenKit's C# implementation. You can keep this for now, but you might consider checking it, if your implementation is there already. |
|
This PR is now obsolete due to the switch to ZenKitCS. |
can be merged after GothicKit/phoenix-shared-interface#42