This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Implement formatting check for long hyphen #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix these ./tor/validation/formatting_validation.py:125:1: E302 expected 2 blank lines, found 1 ./tor/validation/formatting_validation.py:130:1: W293 blank line contains whitespace
TimJentzsch
suggested changes
Aug 8, 2021
TimJentzsch
approved these changes
Nov 25, 2021
TimJentzsch
suggested changes
Nov 25, 2021
|
Here we still need to define the bot response for the volunteers, you can take https://github.com/GrafeasGroup/tor/blob/main/tor/strings/en_US.yml#L209-L319 as examples :) |
TheLonelyGhost
suggested changes
Feb 3, 2022
| """ | ||
| return ( | ||
| FormattingIssue.AUTOGENERATED_LONG_HYPHEN | ||
| if AUTOGENERATED_LONG_HYPHEN_PATTERN.search(transcription) is not None |
There was a problem hiding this comment.
Why not drop the regex and do a simple x in y check?
Suggested change
| if AUTOGENERATED_LONG_HYPHEN_PATTERN.search(transcription) is not None | |
| if "\u2014" in transcription # \u2014 == em dash == "long hyphen" | |
| ], | ||
| ) | ||
| def test_check_for_autogenerated_long_hyphen(test_input: str, should_match: bool) -> None: | ||
| """Test if autogenerated long hyphens are detected.""" |
There was a problem hiding this comment.
The long hyphen isn't always auto-generated, so perhaps "accidental" would be a better descriptor than "autogenerated"?
Side note: if settings for "smart quotes" (and the like) are enabled on macOS, it automatically replaces -- with — there too. Not just mobile. 😄
|
No comments and no meaningful code updates in months. Closing this since it seems pretty stale to me. Feel free to reopen if the mood strikes to pick this up again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too necessary since missing separator check will detect it as well