This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 15
WIP Slack Ping For Transcripts on Tor Posts #357
Open
erenbektas
wants to merge
8
commits into
GrafeasGroup:main
Choose a base branch
from
erenbektas:slack-ping-on-transcript-on-tor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP Slack Ping For Transcripts on Tor Posts #357
erenbektas
wants to merge
8
commits into
GrafeasGroup:main
from
erenbektas:slack-ping-on-transcript-on-tor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sends a message to #general channel on Slack when a transcriber posts a transcription under a ToR post.
TimJentzsch
suggested changes
Aug 25, 2022
itsthejoker
reviewed
Aug 26, 2022
@@ -17,6 +17,8 @@ mod: | |||
formatting_issues: | | |||
I detected formatting issues in the transcription by {author}: {issues} | |||
{link} | |||
transcript_on_tor_post: | | |||
Looks like {user_url} posted a [transcription]({post_url}) on [ToR Post]({tor_post}) instead of posting it on [r/{sub_name}]({post_link}). :facepalm: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This string is going to slack, right? It would probably be better if we use the native slack link formatting.
Suggested change
Looks like {user_url} posted a [transcription]({post_url}) on [ToR Post]({tor_post}) instead of posting it on [r/{sub_name}]({post_link}). :facepalm: | |
Looks like <{user_url}|{user_url}> posted a <{post_url}|transcription> on <{tor_post}|the ToR Post> instead of posting it on <{post_link}|r/{sub_name}>. :facepalm: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright I finally found some more time to work on this. I didn't know that slack had some different formatting for that! Thankss
itsthejoker
reviewed
Aug 28, 2022
erenbektas
changed the title
Slack Ping For Transcripts on Tor Posts
WIP Slack Ping For Transcripts on Tor Posts
Aug 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355
This sends a message to #general channel on Slack when a transcriber posts a transcription under a ToR post.
It should be like:
Note that, following words in this message will be hyperlinked to the related targets: