Skip to content

Commit

Permalink
Merge pull request educates#302 from jorgemoralespou/casecret
Browse files Browse the repository at this point in the history
Fixes secret for embedded CA.
  • Loading branch information
GrahamDumpleton authored Feb 16, 2024
2 parents aaaec76 + fc9e4b8 commit 5fcae49
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ kind: Secret
metadata:
name: #@ "{}-ca".format(data.values.clusterIngress.domain)
namespace: #@ data.values.operator.namespace
type: kubernetes.io/tls
data:
ca.crt: #@ base64.encode(ingress_ca_certificate)
#@ end
Expand Down
8 changes: 8 additions & 0 deletions project-docs/release-notes/version-2.7.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,3 +189,11 @@ Bugs Fixed
the Kubernetes cluster besides Educates. The affected rules were
`disallow-ingress-nginx-custom-snippets`, `restrict-annotations`
`restrict-ingress-paths` and `prevent-cr8escape`.

* The generated CA secret was incorrectly setting the secret type to
`kubernetes.io/tls` which resulted in Kubernetes rejecting it as it didn't
contain `tls.crt` and `tls.key` data attributes as required by Kubernetes
for that type of secret. Secret type should have been left as default generic
opaque data secret. This issue was inadvertantly introduced when support was
added for providing the CA secret as an actual secret rather than being
enmbedded in the data values file when deploying Educates.

0 comments on commit 5fcae49

Please sign in to comment.