-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple rms closest #145
base: master
Are you sure you want to change the base?
Multiple rms closest #145
Conversation
b254b2b
to
34adf58
Compare
@Rlamboll still a draft but wanted to get your thoughts at this stage before I write an example notebook |
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 96.98% 96.35% -0.63%
==========================================
Files 23 23
Lines 1159 1206 +47
Branches 252 257 +5
==========================================
+ Hits 1124 1162 +38
- Misses 16 21 +5
- Partials 19 23 +4
Continue to review full report at Codecov.
|
Hi Zeb, I like the idea of the tool and the syntax for infill multiple seems fine. I find the interrupting loops in the code quite hard to follow, so more comments would be useful, as well as more documentation since it's unusual for a cruncher to have this sort of ability. I'd also do more tests, like a test where it's possible to return the wrong answer for two of the variables without inventing new data - currently you are choosing the right pathway from only one option on the N2O two-pathway use case! |
Is this a synonym for nested loops?
Ok cool will have a think. If you have any more you want to suggest please fire away (if you want to make a PR into this one with the use cases of interest that could also work well). |
No, by interrupting I mean loops featuring continues and breaks. I don't belong to the hard school of "never use these, put it all in an if statement or control your loops" but a few comments would go a long way in increasing readibility. I'm quite busy now and writing tests for this would be low on my to-do list but I can do it in the distant future. |
Ye cool got it
Yep let's leave this sitting as a proof of concept until we find time again |
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: