(16-qpr2) - Gradle, AndroidX, and a number of other fixes. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I971d02ac5bf57f8d14f8ca229334c8739eb2f674
Change-Id: Iacb6da339bd144258e43d0d4d971d584bc1bddd9
* The anti-falsing implementation from HumanInteractionClassifier
regularly prevents easy swipe to answer, requiring multiple
attempts until accepted.
Change-Id: Iebad27f9da7bb8fea6fc663dc99ac6c17d94ed5f
(cherry picked from commit 583e42df0f6f02f1a6c05dbdc5559f42e99c8727)
Change-Id: I920a9c259af5597dfd9a88a72e4ac54cb6e73f7a
Change-Id: I5b840ba257adda69882e1fe19a55510802c45106 Signed-off-by: Jesse Chan <jc@lineageos.org>
This prevents the white launch screen from appearing when the system theme is dark Change-Id: I1ee8ff493910578b5e5c9de67ea1f7390178051a
Change-Id: I9d2ee0bbc7d765e605d6f60c7866565c83dff295
The dark theme colors exist in java/com/android/dialer/theme/hidden/res/values/colors_dialer_light.xml that would be used with AOSPThemeModule. As the app uses framework dark theme instead of the module, copy the dark theme colors to values-night. Change-Id: I02a36b01ba581e62556ce6e0151ff0a35209467a
Ripple on dark should be lighter than background. Change-Id: I01993eac93f29609353ef1e1e9b5dc9a211a640c
* Keep styles that use actionBar as is because it uses normal actionbar * Set light statusbar attribute for some styles Change-Id: I8748aa4d12f8e0c68d14d514ea5a2bd4100ee3ca
* Make background color lighter * Update border radius * Update ripple to follow border radius * Remove the background color, use same as activity * Update the back-icon color to white/black for consistency Change-Id: I648a2bd0da47fec99d8a8457c70451e77ed9f8be
Change-Id: I53b6ee1c70925c50e91270e0b084d777dd8c06f6 Signed-off-by: Joey <joey@lineageos.org>
Change-Id: I0994bd1fd9922f18a08364a0d88426d88cb04b6a
Since incallui doesn't have BLUETOOTH permission, SecurityException occurs when using BluetoothDevice#getAliasName() API. To resolve this issue, add the BLUETOOTH permission. Test: manual - Checked that no crash occurred when switching to audio route with BT connected. Bug: 127236848 Change-Id: I65fa3d6275569e967d9608ac4b1c8ee175b2664d
Add missing permission declaration. Change-Id: Icc71b79831c3045b36ff43cc0884275c1c7cbbc8
Signed-off-by: r3g_5z <june@girlboss.ceo>
09-03 13:08:51.712 4496 4496 E MessageQueue-JNI: Exception in MessageQueue callback: handleReceiveCallback 09-03 13:08:51.713 4496 4496 E MessageQueue-JNI: android.app.Fragment$InstantiationException: Unable to instantiate fragment com.android.dialer.app.settings.DisplayOptionsSettingsFragment: calling Fragment constructor caused an exception 09-03 13:08:51.713 4496 4496 E MessageQueue-JNI: at android.app.Fragment.instantiate(Fragment.java:565) 09-03 13:08:51.713 4496 4496 E MessageQueue-JNI: at android.preference.PreferenceActivity.switchToHeaderInner(PreferenceActivity.java:1245) 09-03 13:08:51.713 4496 4496 E MessageQueue-JNI: at android.preference.PreferenceActivity.switchToHeader(PreferenceActivity.java:1296) 09-03 13:08:51.713 4496 4496 E MessageQueue-JNI: at android.preference.PreferenceActivity.onHeaderClick(PreferenceActivity.java:1093) 09-03 13:08:51.713 4496 4496 E MessageQueue-JNI: at com.android.dialer.app.settings.DialerSettingsActivity.onHeaderClick(DialerSettingsActivity.java:45) Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com> Change-Id: Idef793065ea422e7506f943bc76cd20e60e0a271
Co-authored-by: Danny Baumann <dannybaumann@web.de> Signed-off-by: r3g_5z <june@girlboss.ceo>
MediaRecorder dups the file descriptor that is passed to it. Leaked file descriptors were cleared out eventually by ParcelFileDescriptor finalizer.
reset() can throw an exception, despite docs not mentioning it.
This is achieved by making the whole button grid scrollable.
…, and other misc fixes
…ne/answer buttons.
…ecks, null checks, deprecated checks, etc.
# Conflicts: # AndroidManifest.xml # java/com/android/dialer/app/res/values/colors.xml # java/com/android/dialer/app/settings/CallRecordingSettingsFragment.java # java/com/android/dialer/callrecord/impl/CallRecorderService.java # java/com/android/dialer/main/impl/res/values/styles.xml # java/com/android/incallui/CallButtonPresenter.java # java/com/android/incallui/call/CallRecorder.java # java/com/android/incallui/incall/impl/InCallButtonGridFragment.java
Author
|
Converted to draft while I test for bugs. |
Author
|
Known (I'll fix these after New Years):
I'm also working on a Material Design 3 implementation while I test for bugs under this forum post's approach number 2. I have the main app working fine now. I'm working up updating the in-call UI and the contacts view next. |
Author
|
I've tested just about every functionality. It all seems to be working fine. |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the duplicate pull requests. I thought merging the 16-qpr2 branch with my own would take longer than it did.
Changes since PR #52 :
I'll continue testing to ensure there are no bugs over the next few weeks.