Feature/secondarycallblocking #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same flag is being (correctly) added in onCreate, so on top of being wrong this was also completely unnecessary. Bug: 368579654 Test: atest NotificationAccessConfirmationActivityTest Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e0510a62eba04140e459cdd8232f35087aa3073b) Merged-In: I539fca77a1d136bdd0e4892993020884430b8a4e Change-Id: I539fca77a1d136bdd0e4892993020884430b8a4e
Bug: 372671447 Test: atest Flag: EXEMPT bug fix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e719575e92c1e6bd0b9088663e6c909bccf2b007) Merged-In: Ib36c0a3ba482bcddd53c2c09409ea818e6f43cad Change-Id: Ib36c0a3ba482bcddd53c2c09409ea818e6f43cad
…52812', 'googleplex-android-review.googlesource.com/31117685'] into 25Q1-release. Change-Id: I476252fbbc577755928b3505b52da28e3be5caa8
- This CL has some change to avoid code conflict and keep the bare minimum change. Bug: 382707562 Flag: EXEMPT UX bug fix Test: Verified UX on device (cherry picked from commit 4da20d2) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2cf698d1f4478f5e6a2122f01c82fe78030f482e) Merged-In: I9e600d8f1fd6c273329e05a74079f1e03c209c65 Change-Id: I9e600d8f1fd6c273329e05a74079f1e03c209c65
Flag: EXEMPT bug fix Bug: b/397958254 Test: Manual test. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:63cfd6ed2bde6dcda7746aa4ce8db2397b6d3390) Merged-In: Ic424e30ce4c44ea63ee650bd6c1bcafcd60070a4 Change-Id: Ic424e30ce4c44ea63ee650bd6c1bcafcd60070a4
Flag: EXEMPT bug fix Fix: b/397958254 Test: Manual test. see b/397958254#comment10 (cherry picked from commit b91d21b) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3e0ffb799c949f98b044e45675173ed1f232d015) Merged-In: Ibcd3511edee9b3203c6c0cad68e0988b4b621b39 Change-Id: Ibcd3511edee9b3203c6c0cad68e0988b4b621b39
TEST:none BUG:397958254 Auto-generated-cl: translation import (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c45e23404bd0e623a4e50e607630c2dd4a35e4df) Merged-In: I31a3019d6c97de4d8ba42c3cfe96098614a2a89c Change-Id: I31a3019d6c97de4d8ba42c3cfe96098614a2a89c
…40278', 'googleplex-android-review.googlesource.com/31959562', 'googleplex-android-review.googlesource.com/31986297', 'googleplex-android-review.googlesource.com/32081401'] into 25Q1-release. Change-Id: I2faba842818d3558b2ae82724a7bee174216e6b1
Bug: b/372895305 Test: unit test Flag: EXEMPT bug fix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b2ee5ccf5b79d50cf53a86716042f0e2d7ff42ad) Merged-In: Ife615c78c48a2d6f5b938c880c9c2128c5551644 Change-Id: Ife615c78c48a2d6f5b938c880c9c2128c5551644
Bug: 386216637 Flag: EXEMPT bugfix Test: CTS (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:f5ed187ffb6f5a25ac1c06a1e8b023b0c7d8d4b8) Merged-In: I1be52fcb3d52b8b84353ea00fd57d8360ddd966c Change-Id: I1be52fcb3d52b8b84353ea00fd57d8360ddd966c
… a guest user. Bug: 337774836 Test: m -j256 Settings && atest SettingsRoboTests:ContentProtectionTogglePreferenceControllerTest Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:baf503050fc615c7f663ad09e5adb5ab7e7d99dc) Merged-In: I36173b2e7027765b526dfa2ebca216a7de71e669 Change-Id: I36173b2e7027765b526dfa2ebca216a7de71e669
…01557', 'googleplex-android-review.googlesource.com/31490962', 'googleplex-android-review.googlesource.com/31614329'] into 25Q1-release. Change-Id: I96ccc04d2770e0ba351490e39498c80e9f86f090
This uses the standalone wallpaper picker class from WallpaperPicker2 as seen in the Pixel stock ROM.
The NFC preference in Settings -> Connected devices -> Connection preferences doesn't listen to changes from the NFC tile. (This wasn't an issue in Android 10, because there used to be a SwitchPreference that listened there.)
If no customization is needed, BoolSetting base class can be used directly from XML by adding settings:boolSettingField="<class name> <BoolSetting field name>" to the preference XML definition.
…animation" This reverts commit cdfab94fdab8287e47e6a24bb1700a85ee250484.
It's already present in Developer options, but they are not available in secondary users.
Both override_desktop_mode_features and enable_freeform_support toggle had the same name UI name: "Enable freeform windows".
…ypes Secondary users now can have private profiles as its nested profile.
…ofile types Secondary users now can have private profiles as its nested profile.
This reverts commit 6b6c204.
This is needed to set preferences on other profiles from a parent user,
such as Private Space settings configuration, setting settings for
private profile from its parent user.
Comment this line and above once cleanup is being done for rebasing
changes, by adding # as prefix on this line and above.
fixup! add base classes for {Bool,Int}Setting preference controllers
This is needed to set preferences on other profiles from a parent user,
such as Private Space settings configuration, setting settings for
private profile from its parent user.
Comment this line and above once cleanup is being done for rebasing
changes, by adding # as prefix on this line and above.
fixup! add base classes for {Bool,Int}Setting preference controllers
Adding title for new preference to allow users to block calls
Title of preference to allow user to block calls
Adding preference to ui
Adding logic to show and set the new preference to allow secondaries to block calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GrapheneOS/os-issue-tracker#5569
Settings changes to allow secondary to block calls