Make new document with doubleclicking on empty tab space #3228
Conversation
|
Is the issue you have linked correct? |
i have fixed it now ,sorry |
|
|
||
| <LayoutCol on:pointerdown={() => panelType && editor.handle.setActivePanel(panelType)} class={`panel ${className}`.trim()} {classes} style={styleName} {styles}> | ||
| <LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }}> | ||
| <LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }} on:dblclick={() => editor.handle.newDocumentDialog()}> |
There was a problem hiding this comment.
If you add the click handler to a new element that fills the portion of the bar not occupied by tabs, you won’t need to stop event propagation. I think it feels a little cleaner.
There was a problem hiding this comment.
can you explain a little more?
There was a problem hiding this comment.
I think its about making 2 new LayoutCol. Left one should have contain existing document tab and the right one could have on:dblclick=()
There was a problem hiding this comment.
can you explain a little more?
I mean add a extra child to the tab bar at the end that takes all remaining space.
That child would have the dblclick listener.
Take a look at how I did it in a similar case
|
@timon-schelling can you please take a look at it? |
| let document = snap_data.document; | ||
| let next_handle_start = self.next_handle_start; | ||
| let handle_start = self.latest_point()?.handle_start; | ||
|
|
There was a problem hiding this comment.
Please don't include formatting changes etc. completely outside of the PR scope.
You probably included this by accident, would be helpful if you could double check what you are committing in the future.
No worries, just a heads-up.
| {/if} | ||
| </LayoutRow> | ||
| {/each} | ||
| {#if panelType == 'Document'} |
There was a problem hiding this comment.
Panel is a component used in different contexts... You could instead create a prop for dblclickEmptySpaceAction (I'm tired, could not think of a better name) and use that prop here
clickAction
This is issue number #3215
Make new document with double clicking on empty tab space
Allowing user to create a new file by double clicking on the empty tab space
Recording.2025-09-26.202723.1.mp4
Closes #3215