Add implementation of rasterize node using vello #3232
Conversation
Performance Benchmark Results
|
TrueDoctor
force-pushed
the
rasterize-vello
branch
from
5b7e4a7 to
8c45949
Compare
Performance Benchmark Results
|
|
|
||
| // Render data to Vello scene | ||
| let render_params = graphene_svg_renderer::RenderParams { | ||
| footprint: Footprint::default(), |
There was a problem hiding this comment.
Isn't this included in ..Default::default()?
|
|
||
| // Convert GPU raster to CPU raster using Convert trait | ||
| use graphene_core::ops::Convert; | ||
| let cpu_raster = gpu_raster.convert(Footprint::default(), wgpu_executor).await; |
There was a problem hiding this comment.
Why don't we return a GPU texture here? Vector -> Rasterize -> Invert GPU and similar usecases.
There was a problem hiding this comment.
I wanted this to match the CPU version also to make this usable for the led artwork
There was a problem hiding this comment.
But we should make the two nodes compatible with each other so opening a document created in web also works on desktop
There was a problem hiding this comment.
Could we make two nodes one with CPU and one with GPU output, both using the same utility function to render?
There was a problem hiding this comment.
I'd rather wait until we have proper automatic type conversion, this should ideally not be complexity we expose to the user, if we can avoid it
There was a problem hiding this comment.
We already do with all the oder GPU nodes
There was a problem hiding this comment.
Which is something I want to fix asap
No description provided.