Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display notice on All Views/New View pages when GF is not activated #1989

Merged
merged 12 commits into from
Feb 22, 2024

Conversation

mrcasual
Copy link
Collaborator

@mrcasual mrcasual commented Feb 15, 2024

Ref: #1979

GV notices are reused but made non-dismissible on those two pages.

This prevents "invalid post type" error when accessing trying to
edit or create a new View
This implements #1979 using some "clever hacks" as there's no easy
way to override WP's edit.php and post-new.php output.
@mrcasual mrcasual requested a review from zackkatz February 15, 2024 16:47
@zackkatz zackkatz added this to the 2.20 milestone Feb 21, 2024
@zackkatz
Copy link
Member

@mrcasual Please confirm the use statements in class-gv-view.php. I changed those during merge commit.

use GravityKit\GravityView\Foundation\Helpers\Arr;
use GF_Query;
use GravityView_Compatibility;
use GravityView_Cache;

@zackkatz zackkatz merged commit 5ef6db9 into develop Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants