Removes the filter that removed gf max files validation

[omarkasem]

• This solves Edit Entry doesn't respect File Upload's Maximum Number of Files setting #2086
• The edit entry validation for max files works but after the user clicks edit entry.
• The issue here is the files are uploaded to the uploads folder before they are validated
• Gravity forms already has a good ajax validation for this part but we have a filter that removes that validation in GravityView
  add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
• It says that it was added because our custom validation already handles that so we don't have a conflict ( I tried to find that conflict but couldn't)
• So we can leave it as it is and we would have ajax validation (gf validation) and also a custom validation after the user clicks update (Our validation)
• Or we can keep the filter that removes gf validation and build our own.

[mrcasual]

@rafaehlers, could you please test to ensure that removing our custom validation doesn't unexpectedly break anything?

[omarkasem]

@rafaehlers, could you please test to ensure that removing our custom validation doesn't unexpectedly break anything?

I think you mean removing the filter that removes the gf ajax validation (which is what's been done in this PR)

[rafaehlers]

@omarkasem said:

The issue here is the files are uploaded to the uploads folder before they are validated

I don't see this being a problem! In my tests, this didn't affect anything.

Removing this filter seems to be the solution we needed.