-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local timezone when formatting Time fields #2107
Use local timezone when formatting Time fields #2107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That fixed it! ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrcasual Only reviewed code, not functionality.
Is there a need to replace |COLON|
back to :
?
@zackkatz, it's not needed as the format is directly extracted without going through the parsing function as it was before. |
2bcb4ce
to
07edb8b
Compare
This fixes #2102 and supports various time format characters, including escaped values and colons such as
\a\t\ H\:i\:s
(per our guide).💾 Build file (07edb8b).