Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text-domain error during layout installation #2112

Closed
wants to merge 2 commits into from
Closed

Conversation

Mwalek
Copy link

@Mwalek Mwalek commented Aug 16, 2024

@Mwalek
Copy link
Author

Mwalek commented Aug 16, 2024

@doekenorg as mentioned in the description, this PR is meant to address issue #2110.

The solution is effective but doesn't handle updating/refreshing the dropdown shown in the image below.

Screenshot 2024-08-16 at 9 53 10 PM

The dropdown should, without refreshing the page, show the correct layout (the one that was just selected and installed) and the layout that was just installed should not still appear in the dropdown with an install button.

Could you please provide guidance/a solution for this?

@zackkatz zackkatz requested a review from mrcasual August 16, 2024 20:38
@zackkatz
Copy link
Member

@zackkatz
Copy link
Member

@Mwalek Can you please write an issue about the larger issue about the parts of the View editor not refreshing? This PR will fix the issue #2110, but the bigger issue of the states not being in sync needs to be addressed separately.

@zackkatz zackkatz marked this pull request as ready for review August 19, 2024 15:25
@Mwalek
Copy link
Author

Mwalek commented Aug 19, 2024

Thanks @zackkatz! Here's the new issue:

#2117

mrcasual added a commit that referenced this pull request Aug 28, 2024
This finishes cherry-picking from #2112
@mrcasual mrcasual changed the title Fix text-domain error during layout installation [WIP] Fix text-domain error during layout installation Aug 28, 2024
@mrcasual mrcasual closed this Aug 28, 2024
@mrcasual
Copy link
Collaborator

Changes were merged into develop for release. #2117 will be addressed in a separate PR.

@mrcasual mrcasual changed the title [WIP] Fix text-domain error during layout installation Fix text-domain error during layout installation Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants