Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder in custom searchable fields in search widget #2114

Conversation

omarkasem
Copy link
Collaborator

@omarkasem omarkasem commented Aug 18, 2024

@omarkasem omarkasem linked an issue Aug 18, 2024 that may be closed by this pull request
@omarkasem omarkasem requested a review from mrcasual August 18, 2024 06:24
@mrcasual mrcasual self-assigned this Aug 18, 2024
@mrcasual mrcasual requested a review from Mwalek August 18, 2024 16:33
@mrcasual
Copy link
Collaborator

@Mwalek, please test.

@Mwalek
Copy link

Mwalek commented Aug 19, 2024

@mrcasual the placeholders are only visible for "date range" not for dates. Not sure if this is expected or not.

Date (placeholders absent):

Screenshot 2024-08-19 at 3 58 33 PM

Date range (placeholders present):

Screenshot 2024-08-19 at 3 59 21 PM

@zackkatz zackkatz requested a review from rafaehlers August 19, 2024 15:11
@zackkatz
Copy link
Member

@rafaehlers is going to test this.

@rafaehlers
Copy link
Contributor

@Mwalek Yes, that's expected!

@omarkasem All good! Thanks 🙏

@mrcasual mrcasual merged commit 3455f66 into develop Aug 22, 2024
1 check passed
@mrcasual mrcasual deleted the issue/2113-placeholder-not-set-in-custom-searchable-fields-in-search-widget branch August 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder not set in custom searchable fields in search widget
5 participants