Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1921 layout builder #2164

Merged
merged 29 commits into from
Nov 4, 2024
Merged

Feature/1921 layout builder #2164

merged 29 commits into from
Nov 4, 2024

Conversation

doekenorg
Copy link
Contributor

@doekenorg doekenorg commented Oct 9, 2024

This PR addresses #1921.

I've taken a free interpretation of the designs in Figma, to keep progress up.

Currently it only focusses on Widgets.

  • Some extra styling
  • Multiple Forms button styling
  • Add support for fields (letting templates opt-in; DIY by default?)
  • Global opt-in setting to this behaviour (?)

💾 Build file (59fe662).

@Mwalek
Copy link

Mwalek commented Oct 21, 2024

While doing preliminary testing of this PR I encountered 2 issues.

Issue 1: Custom Content in Top Widget Row Disappears

Custom content added to the top widget row is lost unless paired with a different widget (e.g., the search widget).

Steps to Reproduce:

  1. Delete all rows in the top widget area.
  2. Create a custom row with 2 columns.
  3. Add the "Custom Content" widget to both columns and input content.
  4. Save the View.

After the page refreshes, the custom content disappears.

Issue 2: Unable to Add Rows Without Saving the View First

Let me know if you have any questions :)

Issue Summary

  • Custom Content in Top Widget Row Disappears
  • Unable to Add Rows Without Saving the View First

@doekenorg doekenorg changed the title WIP: Feature/1921 layout builder Feature/1921 layout builder Oct 21, 2024
@doekenorg
Copy link
Contributor Author

@Mwalek @crbdev This is officially ready for full testing. Please include the Layout Builder Template as well. You can find that on the Release Manager.

Casey, I'm tagging you to check if this is (at least good) enough for your demo on Oct 28th.

@Mwalek
Copy link

Mwalek commented Oct 21, 2024

@doekenorg there is still an issue when clicking the "Add row" button under Entries Fields before saving the View. Additionally, you may want to use uppercase "Row" to match the "Add Field" button.

  • Unable to Add Rows Without Saving the View First under Entries Fields
  • Change "Add row" to Title Case (Add Row)

@doekenorg
Copy link
Contributor Author

@Mwalek fixed those.

@Mwalek
Copy link

Mwalek commented Oct 22, 2024

@doekenorg thanks, I confirmed the fixes!

@crbdev
Copy link

crbdev commented Oct 28, 2024

It appears that the "Go back" link is missing. When you go to the Single Entry page, there is no link to go back to the Multiple Entries page. @Mwalek Do you see this too?

@Mwalek
Copy link

Mwalek commented Oct 28, 2024

@crbdev I can't reproduce with build 0a24db8. You can see my test here:

https://basecamp.try.gravitykit.com/collection/lorem-3/item/item-26/

Feel free to create your own tests and change plugin versions on the site.

@crbdev
Copy link

crbdev commented Oct 28, 2024

@Mwalek Can you test again with the latest build in release manager? 0a24db8c6

@Mwalek
Copy link

Mwalek commented Oct 28, 2024

@crbdev that's the same build that I used, no? 🤔

@crbdev
Copy link

crbdev commented Oct 28, 2024

Oh yes. My bad 😬 Okay, I'll see if I can figure out why this is happening.

@zackkatz zackkatz merged commit ebb4ba9 into develop Nov 4, 2024
1 check passed
@zackkatz zackkatz deleted the feature/1921-layout-builder branch November 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants