-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1921 layout builder #2164
Conversation
While doing preliminary testing of this PR I encountered 2 issues. Issue 1: Custom Content in Top Widget Row Disappears Custom content added to the top widget row is lost unless paired with a different widget (e.g., the search widget). Steps to Reproduce:
After the page refreshes, the custom content disappears. Issue 2: Unable to Add Rows Without Saving the View First Let me know if you have any questions :) Issue Summary
|
@doekenorg there is still an issue when clicking the "Add row" button under Entries Fields before saving the View. Additionally, you may want to use uppercase "Row" to match the "Add Field" button.
|
@Mwalek fixed those. |
@doekenorg thanks, I confirmed the fixes! |
It appears that the "Go back" link is missing. When you go to the Single Entry page, there is no link to go back to the Multiple Entries page. @Mwalek Do you see this too? |
@crbdev I can't reproduce with build 0a24db8. You can see my test here: https://basecamp.try.gravitykit.com/collection/lorem-3/item/item-26/ Feel free to create your own tests and change plugin versions on the site. |
@crbdev that's the same build that I used, no? 🤔 |
Oh yes. My bad 😬 Okay, I'll see if I can figure out why this is happening. |
This PR addresses #1921.
I've taken a free interpretation of the designs in Figma, to keep progress up.
Currently it only focusses on Widgets.
💾 Build file (59fe662).