Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/2120 support the new image choice and multiple choice fields in gravity forms 29 #2174

Conversation

omarkasem
Copy link
Collaborator

@omarkasem omarkasem commented Oct 19, 2024

💾 Build file (9f62798).

@omarkasem omarkasem linked an issue Oct 19, 2024 that may be closed by this pull request
5 tasks
@omarkasem omarkasem self-assigned this Oct 19, 2024
@omarkasem omarkasem requested a review from mrcasual October 19, 2024 14:31
@mrcasual
Copy link
Collaborator

@Mwalek, please test.

@rafaehlers
Copy link
Contributor

@Mwalek FYI, there's an instaWP site with 2.9 here:

Form: https://29beta.try.gravitykit.com/wp-admin/admin.php?page=gf_edit_forms&id=44
View: https://29beta.try.gravitykit.com/wp-admin/post.php?post=3139&action=edit

@Mwalek
Copy link

Mwalek commented Oct 21, 2024

@omarkasem the only issue I observed was that the setting "Enable lightbox for images" doesn't work for image choices. Could you please have a look?

@Mwalek Mwalek removed their assignment Oct 21, 2024
@rafaehlers
Copy link
Contributor

rafaehlers commented Oct 21, 2024

@omarkasem the only issue I observed was that the setting "Enable lightbox for images" doesn't work for image choices. Could you please have a look?

@Mwalek Sorry to ask, but why is that important in this scenario? Images used on Image Choice fields shouldn't be expanded or opened in a lightbox. Unless I'm missing something. Let me know.

@Mwalek
Copy link

Mwalek commented Oct 22, 2024

@rafaehlers I wouldn't say it's important, but I would say that it's expected. From a user standpoint, if the "Enable lightbox for images" setting is enabled, they would be expecting ALL images to open in a lightbox, regardless of how the image was added.

Images used on Image Choice fields shouldn't be expanded or opened in a lightbox. Unless I'm missing something.

Is there a particular reason for this? When an image from the Image Choice Field is added it doesn't look very different from an image added via another field, and yet it would perform differently. I think users might find that confusing.

Just my thoughts. We can safely ignore this if the current behavior is intended.

@rafaehlers
Copy link
Contributor

@Mwalek Image Choices are just images added to radio buttons or checkbox fields to help illustrate the choice. It's not related to File Uploads at all. These images can be small icons.

On the form, when you click on a choice to select it, the choice is selected. That's it. The image is not expanded. I don't want a small icon to be expanded inside a lightbox. The View should have a similar behavior.

image

Does that make sense?

@zackkatz zackkatz merged commit e94ea52 into develop Nov 4, 2024
1 check passed
@zackkatz zackkatz deleted the issue/2120-support-the-new-image-choice-and-multiple-choice-fields-in-gravity-forms-29 branch November 4, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the new Image Choice and Multiple Choice fields in Gravity Forms 2.9
5 participants