Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Widget configuration on new View #2175

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

doekenorg
Copy link
Contributor

@doekenorg doekenorg commented Oct 21, 2024

When creating a new View, you can add Widgets to the areas, but you cannot configure them. This is because Ajax request requires at least a template-id, which is not provided; as the value is empty.

This PR addresses this, and updates the templateid and formid for all the widget buttons. This provided the required context for being able to configure the widgets.

💾 Build file (1346fa7).

@doekenorg
Copy link
Contributor Author

Hey @Mwalek, could you test this as well? Found this after investigating the add row error on the Layout Builder.

@Mwalek
Copy link

Mwalek commented Oct 21, 2024

@doekenorg thanks! This is still a problem in Safari and Firefox. It works fine in Chrome.

@doekenorg
Copy link
Contributor Author

@Mwalek I'm pretty sure this a caching issue on your end. Please note is has nothing to do with the Layout Builder in this case. It's purely that; when creating a new View; the widgets can be added; but not configured. There is no configuration cog-icon.

@Mwalek
Copy link

Mwalek commented Oct 21, 2024

Thanks for clarifying @doekenorg ... the confusion was because I thought that this was related to the Layout Builder. All good! I can confirm that the fix is effective in the different browsers.

@Mwalek Mwalek removed their assignment Oct 21, 2024
@mrcasual mrcasual merged commit bbe5db5 into develop Oct 21, 2024
2 checks passed
@doekenorg doekenorg deleted the issue/widgets-can-not-be-added-on-new-view branch October 21, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants