Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Layout Builder to Core #2223

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Move Layout Builder to Core #2223

merged 5 commits into from
Dec 12, 2024

Conversation

doekenorg
Copy link
Contributor

@doekenorg doekenorg commented Nov 27, 2024

This PR addresses #1921

It adds a new Layout, called Layout Builder, that has dynamic rows for the fields.

💾 Build file (33bacbe).

@doekenorg
Copy link
Contributor Author

@Mwalek please test this. I can imagine you finding a lot; because it's a new thing. :-)

@Mwalek
Copy link

Mwalek commented Nov 28, 2024

@doekenorg we'll see 😄

@Mwalek
Copy link

Mwalek commented Dec 3, 2024

@doekenorg @mrcasual no issues were encountered. One minor observation though, is that the image size for the layout builder is different from that of other layout types.

Layout Builder
Screenshot 2024-12-03 at 2 42 30 PM

DataTables
Screenshot 2024-12-03 at 2 43 17 PM

@doekenorg
Copy link
Contributor Author

@zackkatz see the above remark. Could you export that image again in the adjusted size? 😄

@mrcasual
Copy link
Collaborator

@doekenorg, could you please resolve the merge conflict?

@mrcasual mrcasual merged commit 3f0f199 into develop Dec 12, 2024
1 check passed
@mrcasual mrcasual deleted the feature/1921-layout-builder branch December 12, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants