Itzik - Last version of the code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is practically 0 documentation in this document, please add documentation and comments/ |
TheOnion313
requested changes
Nov 4, 2020
There was a problem hiding this comment.
Overall great work
I have left a few comments along the code but generally:
the most major change needed is to change the ball crop function to Ittai's more efficient one
also you should add a general description of the function for each function on top of the parameter and return documentation
we are very close to finshing! good work!
TheOnion313
approved these changes
Nov 30, 2020
The changes are in the main function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is latest version of the code, it runs, I checked.