Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Network Awareness tab and Qrcode generator for VCards #12

Open
wants to merge 6 commits into
base: Main
Choose a base branch
from

Conversation

PjSingh22
Copy link

@PjSingh22 PjSingh22 commented Aug 26, 2023

Date: August 25, 2023

Description:
This pull request adds the NetworkAwareness tab to the application which displays one tab for the users' machine information and another tab to generate a QrCode through a provided VCard.

Changes Made:

  1. Added a new tab named "NetworkInfo" to the views folder that houses the NetworkInfo and QrCode components which are housed in the "network" folder
  2. Added a "NetworkIcon" svg to the icons folder that is shown on the sidebar to navigate to the "NetworkInfo" component
  3. Added "getHostName" and "getLocalIp" methods to the preload.js file to load up the app with the users' data on the launch of the app.
  4. Added "network" route to router/index.js

Testing:
I have tested the app and building the project using "npm run build" returns a green check of "built"

*Node Version: 16.19.0
*Operating System: Linux

Please let me know about any questions you have and thank you for this very fun learning experience!

Best Regards,
Prabhjot Singh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant