Trust relationships ordering update #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadiorchen
approved these changes
Dec 10, 2024
| @@ -74,42 +74,56 @@ const walletGetTrustRelationships = async (req, res) => { | |||
| }); | |||
| const validatedQuery = await walletGetTrustRelationshipsSchema.validateAsync( | |||
| req.query, | |||
| { abortEarly: false }, | |||
| { | |||
There was a problem hiding this comment.
Maybe we shourd force code format on committing, so it makes review easier
|
@pranavkparti there are merge conflicts |
|
🎉 This PR is included in version 1.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the ordering of endpoint
GET /wallets/{wallet_id}/trust_relationshipsto displayrequestedstate records at the top of the returned results.What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
The endpoint returns results without prioritizing records by
requestedstate.What is the new behavior?
Records with state
requestedandtarget_walletas the current wallet or one of its managed wallets will be returned at the top of the results.Breaking change
Does this PR introduce a breaking change?
No.
Other useful information
None.