Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add achievement tasks and world map controls #544

Merged
merged 48 commits into from
Jun 28, 2024
Merged

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented May 30, 2024

  • Add achievement tasks
    • Achievement interface
    • Task tab interface
    • Majority of lumbridge/draynor introductory tasks (missing list below)
    • Task pinning
    • Task map hints
  • Add world map controls
    • Ordering icons in the key
    • Setting map markers
  • Prove script command to support strings
  • Move sprite dump dir into ./temp/
  • Add struct definitions and structs.yml config file
  • Add quest definitions and quests.yml config file
  • Add combat to include summoning level support
  • Add boolean support to "var" command
  • Add shop buy and sell events SoldItem and BoughtItem
  • Explorer Jack to claim coins and item rewards

Fixes:

  • Zamorak monk robe drop ids
  • Interface components sent to visibility packet
  • Incorrect cache task requirements Broken falador task requirement #540
  • Text wrapping to "messages" command
  • Rename bot variables so they don't conflict with task variables
  • Using spells on magic dummy
  • Ellis Tanning
  • Area's not including all levels
  • Wizards tower top floor area

Tasks missing:

  • Blood pact quest
  • Restless ghost quest
  • Come and have a go... - warped fly
  • Three rounds rapid, men - warped bats
  • Flour power
  • Clay of champions
  • Just add water
  • Absolutely enchanting
  • Can't touch this - lumbridge catacombs
  • Myths of the white lands
  • Doom! - lumbridge doomsayer Add Doomsayer & warnings #391
  • Sage advice - lumbridge sage
  • Grinding my gears - lumbridge mill
  • The rules of engagement - draynor manor town crier
  • Grave considerations - father aereck/gravestones Gravestones #542

Copy link

github-actions bot commented May 30, 2024

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 32.90891% with 685 lines in your changes missing coverage. Please review.

Project coverage is 34.09%. Comparing base (5f7a2a0) to head (52ec82e).

Additional details and impacted files
Files Coverage Δ
...gregs/voidps/engine/client/variable/VariableSet.kt 31.57% <100.00%> (+3.80%) ⬆️
...world/gregs/voidps/world/activity/quest/Quests.kts 60.00% <100.00%> (+2.85%) ⬆️
...gs/voidps/world/activity/skill/cooking/Cooking.kts 54.83% <100.00%> (+5.65%) ⬆️
...voidps/world/activity/skill/prayer/BoneBurying.kts 38.09% <100.00%> (+33.09%) ⬆️
...oidps/world/activity/skill/prayer/PrayerAltars.kts 43.75% <100.00%> (+43.75%) ⬆️
...world/activity/skill/runecrafting/Runecrafting.kts 67.85% <100.00%> (+0.78%) ⬆️
...world/activity/transport/teleport/HomeTeleport.kts 60.71% <100.00%> (+57.01%) ⬆️
...ld/gregs/voidps/world/community/trade/lend/Loan.kt 66.66% <100.00%> (+4.16%) ⬆️
...gs/voidps/world/interact/dialogue/type/LevelUp.kts 25.80% <100.00%> (ø)
...gs/voidps/world/interact/entity/death/NPCDeath.kts 60.00% <100.00%> (-0.37%) ⬇️
... and 54 more

... and 29 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #544      +/-   ##
============================================
+ Coverage     33.46%   34.09%   +0.62%     
- Complexity     4652     4762     +110     
============================================
  Files          1277     1291      +14     
  Lines         41786    42766     +980     
  Branches       8864     9151     +287     
============================================
+ Hits          13982    14579     +597     
- Misses        24727    24924     +197     
- Partials       3077     3263     +186     
Components Coverage Δ
Content 27.46% <34.85%> (+1.52%) ⬆️
Engine 43.85% <2.70%> (-0.16%) ⬇️
Network 71.29% <100.00%> (ø)

@GregHib GregHib merged commit 92fcaef into main Jun 28, 2024
5 checks passed
@GregHib GregHib deleted the achievement-tasks branch June 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant