Proper Reloading of OreDict Ing Cache on Servers #2771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the cache reloading of Ore Dict Ingredients, first introduced in #2456, on Dedicated Servers with JEI installed.
Due to the reloading being delegated to the JEI Plugin in such a case, which does not take place on dedicated servers, the original PR did not reload the cache, causing issues with recipes not running whilst appearing in JEI.
See Nomi-CEu/Nomi-CEu#1309 for the corresponding Nomi-CEu PR, and Nomi-CEu/Nomi-Labs@a56bf2a for the corresponding Nomi Labs commit.
Implementation Details
None
Outcome
Fixes issues with recipes not running on dedicated servers, under certain modifications from CT & GS, or premature comparison of recipes containing Ore Dict Ingredients by addons.
Additional Information
None
Potential Compatibility Issues
None